-
Notifications
You must be signed in to change notification settings - Fork 237
Fix Qwen3 recipe and update autoquant example cmd #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: weimingc <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 74.65% 74.66%
=======================================
Files 192 192
Lines 18969 18975 +6
=======================================
+ Hits 14162 14167 +5
- Misses 4807 4808 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if model_type in ["qwen3moe", "qwen3next"] and qformat == "nvfp4": | ||
| # Disable the attention projection layers to retain accuracy | ||
| quant_cfg["quant_cfg"]["model*.*attn*in_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*q_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*k_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*v_proj*"] = {"enable": False} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an option to skip this setting? We are hardcoding skipping of attention here.
Cc @shengliangxu - config system and model based config examples could be helpful to improve the overall experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Right now feel free to add an additional flag for auto quant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can refactor this part once the config system is ready.
What does this PR do?
Type of change: Bug fix
Overview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information